RFR: 8257700: Add logging for sealed classes in JVM_GetPermittedSubclasses [v2]

[Coleen Phillimore]

On Tue, 15 Dec 2020 21:58:09 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

>> Please review this small fix for JDK-8257700 to add logging to JVM_GetPermittedSubclasses().  The fix was tested with Mach5 tiers 1 and 2 on Linux, MacOS, and WIndows, tiers 3-5 on Linux x64, and by running the hotspot runtime sealed tests with -Xlog:class+sealed=trace and looking at the output.
>> 
>> Thanks, Harold
>
> Harold Seigel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8257700: Add logging for sealed classes in JVM_GetPermittedSubclasses

Changes requested by coleenp (Reviewer).

src/hotspot/share/prims/jvm.cpp line 2129:

> 2127:   assert(c->is_instance_klass(), "must be");
> 2128:   InstanceKlass* ik = InstanceKlass::cast(c);
> 2129:   log_trace(class, sealed)("Calling GetPermittedSubclasses for %s type %s",

I don't know why this didn't complain about a missing ResourceMark, but can you add one just before line 2129 and it'll clean up any potential resource area uses for any external_name() calls.  They're not that expensive so one would do without conditionalization.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1780