RFR: 8257700: Add logging for sealed classes in JVM_GetPermittedSubclasses [v2]
David Holmes
dholmes at openjdk.java.net
Wed Dec 16 00:48:02 UTC 2020
On Tue, 15 Dec 2020 21:58:09 GMT, Harold Seigel <hseigel at openjdk.org> wrote:
>> Please review this small fix for JDK-8257700 to add logging to JVM_GetPermittedSubclasses(). The fix was tested with Mach5 tiers 1 and 2 on Linux, MacOS, and WIndows, tiers 3-5 on Linux x64, and by running the hotspot runtime sealed tests with -Xlog:class+sealed=trace and looking at the output.
>>
>> Thanks, Harold
>
> Harold Seigel has updated the pull request incrementally with one additional commit since the last revision:
>
> 8257700: Add logging for sealed classes in JVM_GetPermittedSubclasses
Hi Harold,
Looks good. One minor comment below.
Thanks,
David
src/hotspot/share/prims/jvm.cpp line 2168:
> 2166: // we had invalid entries so we need to compact the array
> 2167: log_trace(class, sealed)(" - compacting array from length %d to %d",
> 2168: length, count);
Not sure this really adds any useful information, but your call.
-------------
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/1780
More information about the hotspot-dev
mailing list