Integrated: 8258252: Move PtrQueue enqueue to PtrQueueSet subclasses

Kim Barrett kbarrett at openjdk.java.net
Wed Dec 16 07:58:14 UTC 2020


On Tue, 15 Dec 2020 05:32:07 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> Please review this refactoring in the PtrQueue/PtrQueueSet hierarchy.
> 
> The functions PtrQueue::enqueue and PtrQueue::enqueue_known_active are
> removed, along with the helper virtual function PtrQueue::handle_completed_buffer.
> 
> Instead we now have G1{Dirty,Redirty}CardQueueSet::enqueue and SATBMarkQueueSet::enqueue/enqueue_known_active, each tailored to the corresponding specific behavior. They use some shared helper routines from PtrQueueSet, and the PtrQueue buffer and index have been made accessible to clients.
> 
> Testing:
> mach5 tier1-3, 5 (stress tests)
> Local (linux-x64) tier1 with -XX:+UseShenandoahGC

This pull request has now been integrated.

Changeset: cdb53422
Author:    Kim Barrett <kbarrett at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/cdb53422
Stats:     364 lines in 22 files changed: 181 ins; 113 del; 70 mod

8258252: Move PtrQueue enqueue to PtrQueueSet subclasses

Reviewed-by: tschatzl, rkennke

-------------

PR: https://git.openjdk.java.net/jdk/pull/1776


More information about the hotspot-dev mailing list