RFR: JDK-8258479: Minor cleanups in VMError [v2]

[Coleen Phillimore]

On Wed, 16 Dec 2020 13:54:09 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> A list of smaller cleanups, each one too small to justify an own issue:
>> 
>> 1) VMError exposes is_error_reported(), fatal_error_in_progress() and get_first_error_tid(). These functions are used from outside to check on the state of error handling. They can be combined and duplicate coding removed. Also, VMError::_error_reported can be removed, since its redundant with VMError::_first_error_tid != -1)
>> 2) A lot of methods are unnecessarily public
>> 3) the `env_var` array in vmError.cpp can be limited to file scope
>> 4) definition of VMError static members should be combined to the start of the cpp file
>> 5) the comment describing VMError::report() is misplaced
>> 6) VMError::reset_signal_handlers() is badly named; nothing is reset here, the secondary signal handler is installed.
>
> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix Windows builds

Looks good! Thank you for this cleanup.

-------------

Marked as reviewed by coleenp (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1802