Integrated: JDK-8258479: Minor cleanups in VMError

[Thomas Stuefe]

On Wed, 16 Dec 2020 12:27:31 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> A list of smaller cleanups, each one too small to justify an own issue:
> 
> 1) VMError exposes is_error_reported(), fatal_error_in_progress() and get_first_error_tid(). These functions are used from outside to check on the state of error handling. They can be combined and duplicate coding removed. Also, VMError::_error_reported can be removed, since its redundant with VMError::_first_error_tid != -1)
> 2) A lot of methods are unnecessarily public
> 3) the `env_var` array in vmError.cpp can be limited to file scope
> 4) definition of VMError static members should be combined to the start of the cpp file
> 5) the comment describing VMError::report() is misplaced
> 6) VMError::reset_signal_handlers() is badly named; nothing is reset here, the secondary signal handler is installed.

This pull request has now been integrated.

Changeset: 178c0018
Author:    Thomas Stuefe <stuefe at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/178c0018
Stats:     140 lines in 8 files changed: 49 ins; 62 del; 29 mod

8258479: Minor cleanups in VMError

Reviewed-by: lfoltan, coleenp

-------------

PR: https://git.openjdk.java.net/jdk/pull/1802