RFR: 8257815: Replace global log2 functions with efficient implementations [v11]
Martin Doerr
mdoerr at openjdk.java.net
Thu Dec 17 12:12:58 UTC 2020
On Wed, 16 Dec 2020 16:52:09 GMT, Claes Redestad <redestad at openjdk.org> wrote:
>> Hi Claes,
>> I noticed that you're using `log2i_exact` in ppc.ad. That's wrong, we're hitting assertions because it's not used for exact powers of 2. Please change to `log2i`. I'll test with that change.
>
>> Hi Claes,
>> I noticed that you're using `log2i_exact` in ppc.ad. That's wrong, we're hitting assertions because it's not used for exact powers of 2. Please change to `log2i`. I'll test with that change.
>
> To have the same semantics as before I guess `log2i_graceful` is the better fit. I picked `log2i_exact` since the variable names suggested they were powers of two.
You're right, looks like `log2i_exact` should be used and only braces are wrong. I'll try to fix it and get back to you. Thanks for your patience.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1663
More information about the hotspot-dev
mailing list