[jdk16] RFR: 8256843: [PPC64] runtime/logging/RedefineClasses.java fails with assert: registers not saved on stack

Thu Dec 17 13:24:57 UTC 2020

On Thu, 17 Dec 2020 11:51:53 GMT, Lutz Schmidt <lucy at openjdk.org> wrote:

> 
> 
> Changes look good. Thanks for fixing.

Thanks for the review!

> Side note (not relevant for approval): Wouldn't it be nice to use the builtin just once and call os::current_stack_pointer() in os::current_frame()?

Yeah this would be nice but then we would be dependent to call inlining by the C++ compiler, i.e. we'd have to fiddle around with _NMT_NOINLINE_ again (btw: we could do the same on [s390 where _NMT_NOINLINE_ is used](https://github.com/openjdk/jdk/blob/83be8a902cee867c0e9d400e762f61896eb6df80/src/hotspot/os_cpu/linux_s390/os_linux_s390.cpp#L197-L203))

-------------

PR: https://git.openjdk.java.net/jdk16/pull/24