RFR: 8258408: SystemDictionary passes TRAPS to functions that don't throw exceptions

[David Holmes]

On 17/12/2020 11:40 pm, Coleen Phillimore wrote:
> On Thu, 17 Dec 2020 07:15:46 GMT, David Holmes <dholmes at openjdk.org> wrote:
> 
>>> Please review some mostly superficial cleanups to the SystemDictionary code.  See issue for more details.
>>>
>>> Tested with tier1-6.
>>
>> Seems okay.
>>
>> Had to think a bit about the exception change.
>>
>> Thanks,
>> David
> 
> Thanks for the review, David.
>> Had to think a bit about the exception change.
> Me too, which is why I changed it. I didn't find a good reason to copy the exception when we didn't need to.

Copy it? It isn't it just saving it to be rethrown after we release the 
lock?

The main reason for that code that I can see is to ensure there is no 
pending exception when we call the rest of the code in that block.

David
-----

> -------------
> 
> PR: https://git.openjdk.java.net/jdk/pull/1808
>