RFR: 8258408: SystemDictionary passes TRAPS to functions that don't throw exceptions [v2]
Coleen Phillimore
coleenp at openjdk.java.net
Fri Dec 18 02:18:00 UTC 2020
On Thu, 17 Dec 2020 15:45:12 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Please review some mostly superficial cleanups to the SystemDictionary code. See issue for more details.
>>
>> Tested with tier1-6.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix typo.
src/hotspot/share/classfile/systemDictionary.cpp line 1785:
> 1783: assert(check != NULL, "definer missed recording success");
> 1784: #endif
> 1785: return probe->instance_klass();
So this copies the exception into a Handle linkage_exception, and clears the exception.
src/hotspot/share/classfile/systemDictionary.cpp line 1797:
> 1795: {
> 1796: MutexLocker mu(THREAD, SystemDictionary_lock);
> 1797: PlaceholderEntry* probe = placeholders()->get_entry(name_hash, name_h, loader_data);
This rethrows the exception at the end of the function.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1808
More information about the hotspot-dev
mailing list