RFR: JDK-8258469: Cleanup remaining safefetch test coding

David Holmes dholmes at openjdk.java.net
Fri Dec 18 04:25:56 UTC 2020


On Wed, 16 Dec 2020 09:20:14 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> JDK-8257828 fixed SafeFetch for non-java-thread situations on all platforms. It also introduced gtests.
> JDK-8185734 fixed the problem that gtests were running without SEH catcher on Windows, preventing us from testing Windows x86 at least.
> 
> Since we have now gtests to test SafeFetch, and since all these issues are fixed, we can remove the related test coding in stubRoutines.cpp.
> 
> Testing: manual gtests and GH actions (the Linux x86 error can be ignored, see https://bugs.openjdk.java.net/browse/JDK-8258481).

LGTM!

Thanks,
David

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1799


More information about the hotspot-dev mailing list