RFR: 8258839: Remove JVM option ExitVMOnVerifyError

Daniel D.Daugherty dcubed at openjdk.java.net
Wed Dec 23 18:27:57 UTC 2020


On Wed, 23 Dec 2020 18:01:57 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

> Please review this change to replace the JVM ExitVMOnVerifyError option with asserts.  The change was tested with tiers 1 and 2 on Linux, Mac OS, and Windows, and tiers 3-5 on Linux x64.
> 
> Thanks, Harold

Changes requested by dcubed (Reviewer).

src/hotspot/share/c1/c1_Runtime1.cpp line 539:

> 537:          "Exception not subclass of Throwable");
> 538: #endif
> 539: 

The "#endif" can be deleted.

src/hotspot/share/c1/c1_Runtime1.cpp line 534:

> 532:   }
> 533: #ifdef ASSERT
> 534:   assert(exception.not_null(), "NULL exceptions should be handled by throw_exception");

The "#ifdef ASSERT" can be deleted.

src/hotspot/share/jvmci/jvmciRuntime.cpp line 261:

> 259:   }
> 260: #ifdef ASSERT
> 261:   assert(exception.not_null(), "NULL exceptions should be handled by throw_exception");

The "#fdef ASSERT" can be deleted.

src/hotspot/share/jvmci/jvmciRuntime.cpp line 267:

> 265:          "Exception not subclass of Throwable");
> 266: #endif
> 267: 

The "#endif" can be deleted.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1882


More information about the hotspot-dev mailing list