RFR: 8238284: [macos] Zero VM build fails due to an obvious typo

David Holmes david.holmes at oracle.com
Mon Feb 3 03:26:12 UTC 2020


Hi Jie,

On 3/02/2020 12:53 pm, jiefu(傅杰) wrote:
> Thanks David.
> 
> Is it OK to be pushed?
> Or shall we wait for one more review?

This seems pretty trivial to me so I think it is okay to push.

Thanks,
David

> Thanks a lot.
> Best regards,
> Jie
> 
> On 2020/2/3, 10:38 AM, "David Holmes" <david.holmes at oracle.com> wrote:
> 
>      Hi Jie,
>      
>      On 31/01/2020 11:55 pm, jiefu(傅杰) wrote:
>      > Hi David,
>      >
>      > Thanks for your review and nice suggestion.
>      >
>      > Updated: http://cr.openjdk.java.net/~jiefu/8238284/webrev.01/
>      >
>      > Testing:
>      >    - zero build tests on both macos and linux/x64.
>      
>      That all seems fine to me.
>      
>      Thanks,
>      David
>      
>      > Thanks a lot.
>      > Best regards,
>      > Jie
>      >
>      >
>      > On 2020/1/31, 8:00 PM, "David Holmes" <david.holmes at oracle.com> wrote:
>      >
>      >      Hi Jie,
>      >
>      >      I note however that the same problem regarding lack of const exists in
>      >      other zero implementations. Should they also be fixed?
>      >
>      > Fixed. Thanks.
>      >
>      >
>      
>      
> 


More information about the hotspot-dev mailing list