8237830: support O_CLOEXEC in os::open on other OS than Linux

Schmidt, Lutz lutz.schmidt at sap.com
Tue Feb 4 15:52:47 UTC 2020


Hi Matthias,

your change looks good. Please remember that I'm not a Reviewer!

I have one little detail you could improve, though: 
Could you please use '{' (curly braces) to enclose the if and else blocks in os_bsd.cpp (as you did in os_aix.cpp)? I don't need to see a new wevrev. 

Thanks,
Lutz

On 28.01.20, 12:31, "hotspot-dev on behalf of Baesken, Matthias" <hotspot-dev-bounces at openjdk.java.net on behalf of matthias.baesken at sap.com> wrote:

    New webrev :
    
    http://cr.openjdk.java.net/~mbaesken/webrevs/8237830.1/
    
    (one 'c' got lost somehow in the older webrev)
    
    Best regards, Matthias
    
    
    > 
    > Hi David , on AIX  I see  O_CLOEXEC  since   AIX 7.1.  Seems it was not
    > supported in 6.1, at least I cannot find it there .
    > 
    > Regarding macOS,   this thread
    > 
    > https://groups.google.com/forum/#!topic/golang-dev/7mmT7o9GYb4
    > 
    > claims it is there since  10.7 .
    > Maybe someone can provide more detailed information ?
    > 
    > Best regards, Matthias
    > 
    > 
    > 
    
    



More information about the hotspot-dev mailing list