RFR: JDK-8238586: [TESTBUG] vmTestbase/jit/tiered/Test.java failed when TieredCompilation is disabled

Igor Ignatyev igor.ignatyev at oracle.com
Sat Feb 8 08:18:25 UTC 2020


pushed.

-- Igor

> On Feb 7, 2020, at 9:25 PM, Jia Huang <huangjia at loongson.cn> wrote:
> 
> Hi Igor,
> 
> Thanks for your review.
> 
> Could you please sponsor it?
> 
> Thanks a lot.
> Best regards,
> Jia.
> 
> 在 2020/2/7 23:47, Igor Ignatev 写道:
>> I’d consider it as trivial.
>> 
>> — Igor
>> 
>>> On Feb 6, 2020, at 11:22 PM, Jia Huang <huangjia at loongson.cn> wrote:
>>> 
>>> Thanks Igor.
>>> 
>>> Is it a trivial patch and OK to be pushed?
>>> Or shall we wait for one more review?
>>> 
>>> Thanks a lot.
>>> Best regards,
>>> Jia.
>>> 
>>>> 在 2020/2/7 14:06, Igor Ignatyev 写道:
>>>> Hi Jia,
>>>> 
>>>> LGTM
>>>> 
>>>> -- Igor
>>>> 
>>>>>> On Feb 6, 2020, at 1:20 AM, Jia Huang <huangjia at loongson.cn> wrote:
>>>>> Hi all,
>>>>> 
>>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8238586
>>>>> 
>>>>> When TieredCompilation is disabled, the test will fail.
>>>>> Please review the following fix which make the test pass when disabled TieredCompilation.
>>>>> ------------------------------------------------------
>>>>> diff -r e45d8ca836b5 -r 67bef3d6692f test/hotspot/jtreg/vmTestbase/jit/tiered/Test.java
>>>>> --- a/test/hotspot/jtreg/vmTestbase/jit/tiered/Test.java  Mon Feb 03 22:10:59 2020 +0800
>>>>> +++ b/test/hotspot/jtreg/vmTestbase/jit/tiered/Test.java  Thu Feb 06 15:25:19 2020 +0800
>>>>> @@ -46,7 +46,7 @@
>>>>>  import jdk.test.lib.process.ProcessTools;
>>>>> 
>>>>>  public class Test {
>>>>> -    private static String UNSUPPORTED_OPTION_MESSAGE = "-XX:TieredCompilation not supported in this VM";
>>>>> +    private static String UNSUPPORTED_OPTION_MESSAGE = "-XX:+TieredCompilation not supported in this VM";
>>>>>      private static String REGEXP = "^[0-9.]+: \\[compile level=\\d";
>>>>>      public static void main(String[] args) throws Exception {
>>>>>          {
>>>>> @@ -56,7 +56,7 @@
>>>>>                      "-XX:+PrintTieredEvents",
>>>>>                      "-version");
>>>>>              var output = new OutputAnalyzer(pb.start());
>>>>> -            if (output.getStdout().contains(UNSUPPORTED_OPTION_MESSAGE)) {
>>>>> +            if (output.getStderr().contains(UNSUPPORTED_OPTION_MESSAGE)) {
>>>>>                  throw new SkippedException(UNSUPPORTED_OPTION_MESSAGE);
>>>>>              }
>>>>>              output.shouldHaveExitValue(0)
>>>>> ------------------------------------------------------
>>>>> For more info, please see the JBS.
>>>>> 
>>>>> Thanks a lot
>>>>> 
>>>>> Best regards,
>>>>> Jia.
>>>>> 
> 



More information about the hotspot-dev mailing list