Testing assistance requested: ARM/PPC/S390 and a little Aarch64

David Holmes david.holmes at oracle.com
Mon Feb 10 22:22:53 UTC 2020


Hi Andrew,

On 11/02/2020 2:17 am, Andrew Haley wrote:
> On 2/10/20 7:15 AM, David Holmes wrote:
>> I was hoping some folk may be able to take this preliminary patch for a
>> spin for me as I don't have access to a full range of hardware:
>>
>> http://cr.openjdk.java.net/~dholmes/8234372/webrev/
>>
>> The patch relates to:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8234372
>>
>> 'Investigate use of Thread::stack_base() and queries for "in stack"'
>>
>> The main functional changes here are in frame::safe_for_sender where we
>> bring ARM/PPC/S390/Sparc into line with x86 and Aarch64 with regards to
>> incorrect uses of >= or <= when comparing values with Thread::stack_base().
>>
>> In addition this standardises the main sp safety check to reuse
>> Thread::is_in_usable_stack().
>>
>> And finally (with regards to the testing request) it fixes the validity
>> check for "locals" wrt. Thread::stack_base().
> 
> Looks OK. Passes all smoke tests; is there anything else you'd like me to
> do?

Many thanks for that. If you could chime in on the RFR when it comes out 
that would be good. :)

Thanks,
David



More information about the hotspot-dev mailing list