[15] RFR (M): 8238681: Make -XX:UseSSE flag x86-specific

David Holmes david.holmes at oracle.com
Tue Feb 11 05:08:05 UTC 2020


Hi Vladimir,

On 11/02/2020 12:19 am, Vladimir Ivanov wrote:
> http://cr.openjdk.java.net/~vlivanov/8238681/webrev.00/
> https://bugs.openjdk.java.net/browse/JDK-8238681
> 
> Turn UseSSE into x86-specific flag since it doesn't have any meaning on 
> non-x86 platforms.

That part seems okay.

> As a cleanup, I made all the code which assumes UseSSE<2 x86-32 
> specific. (x86-64 ABI requires SSE2.)

This made things more obscure for me so I'll leave it to compiler folk 
to validate.

> Also, as a precaution, I made UseSSE obsolete on non-x86 platforms.

I took the liberty of filing a very short CSR request for this and added 
myself as Reviewer. Please change it to "Finalized" and await approval 
before pushing.

Thanks,
David

> Testing: hs-precheckin-comp, tier1-5, linux x86-32 fastdebug build.
> 
> Thanks!
> 
> Best regards,
> Vladimir Ivanov


More information about the hotspot-dev mailing list