RFR: 8237830: support O_CLOEXEC in os::open on other OS than Linux
Baesken, Matthias
matthias.baesken at sap.com
Thu Feb 13 08:56:11 UTC 2020
Hi David, thanks for the review .
I'll follow your " One nit:" advice !
Best Regards, Matthias
>
> On 12/02/2020 6:31 pm, Baesken, Matthias wrote:
> > New webrev :
> >
> > http://cr.openjdk.java.net/~mbaesken/webrevs/8237830.3/
> >
> > * this time , only touching os_aix.cpp ( I leave os_bsd.cpp as it
> > is , might
> >
> > make the discussion more simple )
> >
> > * Added handling of failing O_CLOEXEC (
> O_CLOEXEC_is_known_to_work
> >
> > == -1 … case )
>
> Seems okay.
>
> One nit:
>
> ! int oflag_with_o_cloexec = oflag;
> ! oflag_with_o_cloexec |= O_CLOEXEC;
>
> could just be:
>
> ! int oflag_with_o_cloexec = oflag | O_CLOEXEC;
>
> Thanks,
> David
>
More information about the hotspot-dev
mailing list