RFR [XS]: 8239000: handle ContendedPaddingWidth in vm_version_ppc
Schmidt, Lutz
lutz.schmidt at sap.com
Mon Feb 17 10:34:07 UTC 2020
OK, Matthias.
I wasn't aware of this variability. Looks like the ARM gurus will have to take care of that, should it become necessary.
Thanks,
Lutz
On 17.02.20, 11:00, "Baesken, Matthias" <matthias.baesken at sap.com> wrote:
Hi Lutz,
>
> Hi Matthias,
>
> your change looks good to me. Please note: I'm not a reviewer!
>
> I have one question, though. Is there a reason why you only make ppc "look
> like the other architectures"? aarch64 is missing that code as well.
>
The cache line size situation seems to be a little bit complicated on different aarch HW, see for instance the discussion here :
https://github.com/littlekernel/lk/issues/172
So I just changed ppc for now .
Best regards, Matthias
> Thanks for considering!
> Lutz
>
> On 13.02.20, 12:18, "hotspot-dev on behalf of Baesken, Matthias" <hotspot-
> dev-bounces at openjdk.java.net on behalf of matthias.baesken at sap.com>
> wrote:
>
> Hello, please review this small adjustment to vm_version_ppc .
>
> The ContendedPaddingWidth parameter should be handled in
> vm_version_ppc like it is done on other architectures (x86/s390). See
> vm_version_sparc/s390/x86 .cpp for comparision.
>
>
> Bug/webrev :
>
> https://bugs.openjdk.java.net/browse/JDK-8239000
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8239000.0/
>
>
> Best regards, Matthias
>
More information about the hotspot-dev
mailing list