RFR (S) 8239492: [x86] Turn MacroAssembler::verify_oop into macro recording file and line

[Reingruber, Richard]

Hi Aleksey,

> Suggested fix:
>   https://cr.openjdk.java.net/~shade/8239492/webrev.02/

The RFE is worth the (small) effort and the proposed change looks good to me.

I was a little confused as now the verify_oop() calls in TemplateTable get dispatched directely to
MacroAssembler, but that's what InterpreterMacroAssembler::verify_oop() used to do there anyway,
because all the call sites got the default argument state = atos.

I assume you deliberately did the renaming in zVerify.cpp instead of undefining verify_oop as in
shenandoahVerifier.cpp. That's good for me too.

You should update the years in the copyright headers.

Thanks,
Richard. // not a Reviewer


-----Original Message-----
From: hotspot-dev <hotspot-dev-bounces at openjdk.java.net> On Behalf Of Aleksey Shipilev
Sent: Freitag, 21. Februar 2020 11:40
To: hotspot-dev at openjdk.java.net
Subject: RFR (S) 8239492: [x86] Turn MacroAssembler::verify_oop into macro recording file and line

RFE:
  https://bugs.openjdk.java.net/browse/JDK-8239492

This is done in SPARC and ARM MacroAssemblers, and should be done in x86 too. This should greatly
improve the error reports, as it would point to exact place where the verification happened, e.g. in
interpreter/stub generation code.

Suggested fix:
  https://cr.openjdk.java.net/~shade/8239492/webrev.02/

Testing: tier1 {x86_32, x86_64} with -XX:+VerifyOops, jdk-submit (clean, except unrelated Solaris
gtest failure)

-- 
Thanks,
-Aleksey