RFR 8232759: Remove or simplify GC.class_stats

Ioi Lam ioi.lam at oracle.com
Wed Jan 8 17:05:28 UTC 2020


Hi Coleen,

The changes look good to me. Thanks for cleaning up the mess that I 
introduced :-)

- Ioi

On 1/8/20 6:26 AM, coleen.phillimore at oracle.com wrote:
>
>
> On 1/8/20 12:55 AM, David Holmes wrote:
>> Hi Coleen,
>>
>> On 8/01/2020 10:23 am, coleen.phillimore at oracle.com wrote:
>>> Summary: Make the GC.class_stats option obsolete
>>>
>>> open webrev at 
>>> http://cr.openjdk.java.net/~coleenp/2019/8232759.01/webrev
>>> bug link https://bugs.openjdk.java.net/browse/JDK-8232759
>>
>> The fan out from that was larger than I was expecting :)
>
> Yes.  If we wanted such a thing to affect all metadata classes like 
> this, there is metaspace_pointers_do() now that should be used instead.
>>
>> Change appears fine. May I suggest updating the bug to get rid of the 
>> "or simplify" part.
>
> Ok.
> Thanks!
> Coleen
>>
>> Thanks,
>> David
>>
>>> Tested with tier1 on all Oracle platforms and tier2,3 on 
>>> linux-x64-debug.
>>>
>>> Thanks,
>>> Coleen
>>>
>



More information about the hotspot-dev mailing list