RFR 8235678: Remove unnecessary calls to Thread::current() in MutexLocker calls
Harold Seigel
harold.seigel at oracle.com
Tue Jan 14 16:27:17 UTC 2020
Hi Lois,
Thanks for the review!
>> line #1507: Curious to know why you use "THREAD" and the MutexLocker
mu1 at line #1502 uses "thread"?
I used THREAD when available because it is more typically used, but I
didn't change those calls that used JavaThread* objects.
Harold
On 1/14/2020 10:05 AM, Lois Foltan wrote:
> On 1/14/2020 9:00 AM, Harold Seigel wrote:
>> Hi,
>>
>> Please review this small change, to reduce unnecessary calls to
>> Thread::current() in MutexLocker calls, by passing the current thread
>> as an argument. A few ResoureMark declarations were also changed.
>>
>> Open Webrev:
>> http://cr.openjdk.java.net/~hseigel/bug_8235678/webrev/index.html
>>
>> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8235678
>>
>> The fix was regression tested by running Mach5 tiers 1 and 2 tests
>> and builds on Linux-x64, Solaris, Windows, and Mac OS X, by running
>> Mach5 tiers 3-5 tests on Linux-x64, and JCK lang and VM tests on
>> Linux-x64.
>>
>> Thanks, Harold
>>
>
> Overall looks great. One comment:
>
> - prims/methodHandles.cpp
> line #1507: Curious to know why you use "THREAD" and the MutexLocker
> mu1 at line #1502 uses "thread"?
>
> Thanks,
> Lois
More information about the hotspot-dev
mailing list