[PING2!] RFR: 8230305: Cgroups v2: Container awareness

Severin Gehwolf sgehwolf at redhat.com
Thu Jan 16 09:19:36 UTC 2020


Hi David,

On Thu, 2020-01-16 at 08:13 +1000, David Holmes wrote:
> Hi Bob, Severin,
> 
> On 15/01/2020 6:04 am, Bob Vandette wrote:
> > Cgroup V2 is about to go mainstream this year for popular distros such as Oracle Linux 8, Redhat Linux 8 and Fedora
> > so this fix it’s important to get into JDK 15 so we can start shaking out this support.
> > 
> > Please take a look and help get this change reviewed.
> 
> I've taken a look and the overall structure and approach seems fine. I 
> can't attest to the details of cgroups v1 versus v2 but trust the exports.
> 
> Reviewed.

Thanks for the review!

> Please ensure all copyrights updated to 2020.

Yes, I'll update copyrights, remove the synthesized memory_max_usage
(to preserve symmetry with Java changes), run through jdk/submit, and
my local testing (cgroup v2 and cgroup v1) and push.

Thanks,
Severin



More information about the hotspot-dev mailing list