[15] RFR(XS): 8237479: 8230305 causes slowdebug build failure
Daniel D. Daugherty
daniel.daugherty at oracle.com
Sun Jan 19 22:09:37 UTC 2020
Thanks. Tier2 passed...
Dan
On 1/19/20 2:38 PM, Severin Gehwolf wrote:
> Thanks for the quick reviews! Pushed.
>
> Cheers,
> Severin
>
> On Sun, 2020-01-19 at 09:16 -0500, Daniel D. Daugherty wrote:
>> Thumbs up!
>>
>> Please push as soon as you can to unbreak our CI's Tier2 builds.
>> Thanks!
>>
>> Dan
>>
>>
>> On 1/18/20 7:07 PM, David Holmes wrote:
>>> Hi Severin,
>>>
>>> Looks fine and trivial.
>>>
>>> Thanks,
>>> David
>>>
>>> On 19/01/2020 6:57 am, Severin Gehwolf wrote:
>>>> Hi,
>>>>
>>>> My push of hotspot's cgroup v2 support (JDK-8230305) broke the
>>>> slowdebug build. Sorry about this :-/ The issue is that
>>>> CgroupController and CgroupSubsystem are abstract classes and I
>>>> missed
>>>> to declare virtual functions as pure.
>>>>
>>>> This patch fixes that.
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8237479
>>>> webrev:
>>>> http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8237479/01/webrev/
>>>>
>>>> Testing: slowdebug/fastdebug/release builds work on Linux x86_64.
>>>> Currently running through jdk/submit.
>>>>
>>>> Thoughts?
>>>>
>>>> Thanks,
>>>> Severin
>>>>
More information about the hotspot-dev
mailing list