RFR(M): 8245226: Clean-up FlagSetting and remove misuse.

[David Holmes]

Hi Patric,

On 9/07/2020 5:17 am, Patric Hedlin wrote:
> Dear all,
> 
> I would like to ask for help to review the following change/update:
> 
> Issue:  https://bugs.openjdk.java.net/browse/JDK-8245226
> Webrev: http://cr.openjdk.java.net/~phedlin/tr8245226/
> 
> 
> FlagSetting is sometimes used as a general mechanism for local 
> save/modify and restore. This is not the intention (it should work as a 
> red-flag when modifying debug options). Instead, use a general mechanism 
> in these cases (introduced in here), and preserve FlagSetting for its 
> intended purpose (including clean-up).

Sorry but I'm not seeing why FlagSetting can't be used as a general 
mechanism even though it is described as being for debug flags. 
Introducing a similar mechanism seems redundant to me.

Thanks,
David

> 
> Testing: hs-tier1-3
> 
> 
> Best regards,
> Patric