RFR(S): 8248901: Signed immediate support in .../share/assembler.hpp is broken.

[Vladimir Kozlov]

+1

Thanks,
Vladimir K

On 7/7/20 6:59 AM, Nils Eliasson wrote:
> Hi Patric,
> 
> Your change looks good.
> 
> Best regards,
> Nils
> 
> On 2020-07-07 13:00, Patric Hedlin wrote:
>> Dear all,
>>
>> I would like to ask for help to review the following change/update:
>>
>> Issue:  https://bugs.openjdk.java.net/browse/JDK-8248901
>> Webrev: http://cr.openjdk.java.net/~phedlin/tr8248901/
>>
>>
>> Current definition(s) of is_simm() and friends are not robust over inputs. Both min and max values are undefined for 
>> width > 32 (and width < 0).
>> No is_uimm() is currently provided (added). Several definitions are not used (cleanup).
>>
>> NOTE: Adding currently unused is_simm9() and is_uimm12(), required by JDK-8247766.
>>
>>
>> Testing: hs-tier1-3
>>
>>
>> Best regards,
>> Patric
>