RFR(S): 8248901: Signed immediate support in .../share/assembler.hpp is broken.
Tobias Hartmann
tobias.hartmann at oracle.com
Mon Jul 20 07:46:34 UTC 2020
Hi Patric,
looks good to me.
Best regards,
Tobias
On 07.07.20 13:00, Patric Hedlin wrote:
> Dear all,
>
> I would like to ask for help to review the following change/update:
>
> Issue: https://bugs.openjdk.java.net/browse/JDK-8248901
> Webrev: http://cr.openjdk.java.net/~phedlin/tr8248901/
>
>
> Current definition(s) of is_simm() and friends are not robust over inputs. Both min and max values
> are undefined for width > 32 (and width < 0).
> No is_uimm() is currently provided (added). Several definitions are not used (cleanup).
>
> NOTE: Adding currently unused is_simm9() and is_uimm12(), required by JDK-8247766.
>
>
> Testing: hs-tier1-3
>
>
> Best regards,
> Patric
More information about the hotspot-dev
mailing list