RFR(XS) 8248671: AArch64: Remove unused variables

[Bernhard Urban-Forster]

Hello Andrew and David,

is this fine to push? If yes, I need a someone to do that for me as I'm not a committer.


Thank you,
-Bernhard

________________________________________
From: Bernhard Urban-Forster <beurba at microsoft.com>
Sent: Monday, July 13, 2020 16:03
To: David Holmes; aarch64-port-dev at openjdk.java.net; hotspot-dev at openjdk.java.net; hotspot-compiler-dev at openjdk.java.net
Cc: openjdk-aarch64
Subject: RE: RFR(XS) 8248671: AArch64: Remove unused variables

Thank you for your review Andrew and David.

Here is the webrev based on https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fhg.openjdk.java.net%2Fjdk%2Fjdk%2F&data=02%7C01%7Cbeurba%40microsoft.com%7Ce351ec469c9e4d3811b308d82735964b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637302458392009746&sdata=0bdkk1qjXh0nVQWUOavsNQdqIS%2BHdpQASr5ib3ZsyWs%3D&reserved=0:

https://nam06.safelinks.protection.outlook.com/?url=http:%2F%2Fcr.openjdk.java.net%2F~burban%2F8248671_hg%2F&data=02%7C01%7Cbeurba%40microsoft.com%7Ce351ec469c9e4d3811b308d82735964b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637302458392009746&sdata=O2FLNRWUQ8%2BWa%2Bh1uHvn3SQYTUe6bo3qeUYiPvZz%2FAg%3D&reserved=0


Thanks,
-Bernhard

> -----Original Message-----
> From: David Holmes <david.holmes at oracle.com>
> Sent: Monday, July 13, 2020 6:08 AM
> To: Bernhard Urban-Forster <beurba at microsoft.com>; aarch64-port-
> dev at openjdk.java.net; hotspot-dev at openjdk.java.net; hotspot-compiler-
> dev at openjdk.java.net
> Subject: Re: RFR(XS) 8248671: AArch64: Remove unused variables
>
> Hi Bernhard,
>
> On 10/07/2020 7:08 am, Bernhard Urban-Forster wrote:
> > Hello everyone,
> >
> >
> > please review this change:
> >
> > JBS:
> > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs
> > .openjdk.java.net%2Fbrowse%2FJDK-
> 8248671&data=02%7C01%7Cbeurba%40m
> >
> icrosoft.com%7Cfa08ce93e8d44b4f38a708d826e296ed%7C72f988bf86f141af
> 91ab
> >
> 2d7cd011db47%7C1%7C0%7C637302101922573034&sdata=Bv6Fsw104
> ZizId5EdC
> > %2BTnV8DrJCJyQzVk9ht6rWjLMw%3D&reserved=0
> > Webrev:
> > https://nam06.safelinks.protection.outlook.com/?url=http:%2F%2Fcr.open
> > jdk.java.net%2F~burban%2F8248671_unused-
> vars%2F&data=02%7C01%7Cbeu
> >
> rba%40microsoft.com%7Cfa08ce93e8d44b4f38a708d826e296ed%7C72f988bf
> 86f14
> >
> 1af91ab2d7cd011db47%7C1%7C0%7C637302101922573034&sdata=X7
> 7Ri2iWLkm
> > %2FOSmdP9HyEWEwMA7rO%2BM6oKVRAg4zHGQ%3D&reserved=0
> >
> > We found this issue while bringing up Windows+AArch64 support for
> HotSpot. The Microsoft toolchain (MSVC) seems to be slightly more pedantic
> than GCC.
>
> Looks good and trivial.
>
> But could I request that webrevs/patches for mainline be generated against the
> mainline hg repository rather than the git mirror.
>
> Thanks,
> David
>
> >
> > Thanks,
> > -Bernhard
> >