RFR: 8249945: Improve ARRAY_SIZE()

Kim Barrett kim.barrett at oracle.com
Thu Jul 23 09:36:19 UTC 2020


> On Jul 23, 2020, at 4:42 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
> 
> Hi,
> 
> On 23.07.20 09:31, Kim Barrett wrote:
>> Please review this reimplementation of the ARRAY_SIZE() macro.  The
>> new implementation rejects pointer types instead of quietly returning
>> the wrong value; see the CR for more details.
>> CR:
>> https://bugs.openjdk.java.net/browse/JDK-8249945
>> Webrev:
>> https://cr.openjdk.java.net/~kbarrett/8249945/open.00/
>> Testing:
>> mach5 tier1
> 
>  lgtm.

Thanks.

> Fwiw, in JIRA, for regular bugs/enhancements, markdown is disabled in the descriptions afaik, so the tags you added there are kind of out of place. They only work in JEPs.

Yeah, I noticed that later.  I left the tags anyway because I think they make the text a bit clearer
by being explicit about what’s example code and what’s description / commentary.



More information about the hotspot-dev mailing list