RFR (S) 8249822: SymbolPropertyTable creates an extra OopHandle per entry
coleen.phillimore at oracle.com
coleen.phillimore at oracle.com
Thu Jul 23 14:46:07 UTC 2020
Thanks Erik. I added the assert to replace() and reran tier1 and 3 tests.
Coleen
On 7/23/20 10:40 AM, Erik Österlund wrote:
> Hi Coleen,
>
> Looks good. One thing though: in the replace() function, assert that
> the obj_ptr != NULL instead of silently doing nothing.
>
> Don't need another webrev.
>
> Thanks,
> /Erik
>
> On 2020-07-22 22:55, coleen.phillimore at oracle.com wrote:
>> Summary: Add an assert to OopHandle assigment operator to catch
>> leaking OopHandles, and fix code accordingly.
>>
>> There are some jvmtiRedefineClasses.cpp changes here - basically, I
>> moved the RedefineVerifyMark and comments into
>> jvmtiRedefineClasses.cpp because I needed a Handle.
>>
>> Ran tier1-6 tests and tier1 on all Oracle platforms.
>>
>> open webrev at
>> http://cr.openjdk.java.net/~coleenp/2020/8249822.01/webrev
>> bug link https://bugs.openjdk.java.net/browse/JDK-8249822
>>
>> Thanks,
>> Coleen
>
More information about the hotspot-dev
mailing list