RFR (T) 8250042: Clean up methodOop and method_oop names from the code
David Holmes
david.holmes at oracle.com
Fri Jul 24 05:01:21 UTC 2020
Hi Coleen,
On 24/07/2020 2:58 am, coleen.phillimore at oracle.com wrote:
> See bug for more details. I've been running into these names a lot
> lately. Many of these names are in JVMTI.
>
> Tested with tier1 on all Oracle platforms and built on non-Oracle
> platforms.
>
> open webrev at http://cr.openjdk.java.net/~coleenp/2020/8250042.01/webrev
> bug link https://bugs.openjdk.java.net/browse/JDK-8250042
src/hotspot/cpu/*/*.ad
These still refer to "method oop" and method_oop in a number of places.
src/hotspot/share/adlc/adlparse.cpp
+ frame->_interpreter_method_oop_reg = parse_one_arg("method reg entry");
I guess I'm not understanding the scope of this renaming - why is
_interpreter_method_oop_reg not renamed as well? Should this (and other
uses) be parsed as method-(oop-reg) rather than (method-oop)-reg?
Otherwise all okay.
Thanks,
David
> Thanks,
> Coleen
More information about the hotspot-dev
mailing list