RFR: 8250670: TestJFRIntrinsic.java should be run with and without JFR to check the intrinsic properly

Mario Torre neugens at redhat.com
Tue Jul 28 12:55:28 UTC 2020


Hi all,

We noticed an interesting thing with TestJFRIntrinsic.java, if I
understood the test correctly, it wants to check the behavior of the
getEventWriter intrinsic, however it doesn't really do this, since JFR
is always disabled when the test starts, the instance is always null.

I changed the test slightly, first of all it's run twice now (actually
4 times, since it was already run twice before with different values
of the TieredStopAtLevel option), one with and one without JFR, I also
check that for the given combinations we get something resembling
meaningful results.

Here's the webrev:

http://cr.openjdk.java.net/~neugens/8250670/

Any comments?

Cheers,
Mario
-- 
Mario Torre
Associate Manager, Software Engineering
Red Hat GmbH <https://www.redhat.com>
9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898



More information about the hotspot-dev mailing list