8246648: issue with OperatingSystemImpl getFreeSwapSpaceSize in docker after 8242480

Bob Vandette bob.vandette at oracle.com
Fri Jun 5 18:41:33 UTC 2020


I’m good with this fix.

Bob.


> On Jun 5, 2020, at 6:17 AM, Baesken, Matthias <matthias.baesken at sap.com> wrote:
> 
> Hi Severin,
> 
>> In summary: Patch looks OK to me.
> 
> Thanks for the review. 
> May I have a second review ?
> 
> 
> 
>> This comment --^ is wrong. Should be "we see a limit == -1 ..."
>> 
>> 65                 return (limit < memLimit) ? 0 : limit - memLimit;
>> 66             }
>> 
>> Not sure if you want to change that as part of this patch.
> 
> Better not in this change .
> 
> Best regards, Matthias



More information about the hotspot-dev mailing list