RFR [XS]: 8244196: adjust output in os_linux

[Stefan Karlsson]

On 2020-06-09 08:48, Baesken, Matthias wrote:
>> It's not easy at all to read. Would you mind if I changed this to:
> Hi Stefan,  I think your idea to use a more compact output is fine .

Thanks!

StefanK

>
> Best regards, Matthias
>
>
> -----Original Message-----
> From: Stefan Karlsson <stefan.karlsson at oracle.com>
> Sent: Montag, 8. Juni 2020 20:21
> To: Baesken, Matthias <matthias.baesken at sap.com>; 'hotspot-dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
> Subject: Re: RFR [XS]: 8244196: adjust output in os_linux
>
> Hi all,
>
> I encountered the output of this today, and I think the current output
> looks pretty bad. From my hs_err file I have this:
>
> CPU:total 32 (initial active 32) (8 cores per cpu, 2 threads per core)
> ... much more ...
> Online cpus:
> 0-31
> Offline cpus:
>
> cache level:
> 1
> cache type:
> Data
> cache size:
> 32K
> cache coherency line size:
> 64
> cache level:
> 1
> cache type:
> Instruction
> cache size:
> 32K
> cache coherency line size:
> 64
> cache level:
> 2
> cache type:
> Unified
> cache size:
> 256K
> cache coherency line size:
> 64
> cache level:
> 3
> cache type:
> Unified
> cache size:
> 20480K
> cache coherency line size:
> 64
> BIOS frequency limitation:
> <Not Available>
> Frequency switch latency (ns):
> 0
> Available cpu frequencies:
> <Not Available>
> Maximum cpu frequency:
> 3200000
> Minimum cpu frequency:
> 1200000
> Current cpu frequency:
> 2799113
> Available governors:
> performance powersave
> Current governor:
> powersave
> Core performance/turbo boost:
> <Not Available>
>
> It's not easy at all to read. Would you mind if I changed this to:
> Online cpus: 0-31
> Offline cpus:
> cache level: 1
> cache type: Data
> cache size: 32K
> cache coherency line size: 64
> cache level: 1
> cache type: Instruction
> cache size: 32K
> cache coherency line size: 64
> cache level: 2
> cache type: Unified
> cache size: 256K
> cache coherency line size: 64
> cache level: 3
> cache type: Unified
> cache size: 20480K
> cache coherency line size: 64
> BIOS frequency limitation: <Not Available>
> Frequency switch latency (ns): 0
> Available cpu frequencies: <Not Available>
> Maximum cpu frequency: 3200000
> Minimum cpu frequency: 1200000
> Current cpu frequency: 1870913
> Available governors: performance powersave
> Current governor: powersave
> Core performance/turbo boost: <Not Available>
>
> I don't think we should be too afraid of changing the lines here. We've
> have been changing other parts of the hs_err files, and if anyone is
> scraping this info, I think they'll need to adapt.
>
> Thanks,
> StefanK
>
> On 2020-04-30 17:46, Baesken, Matthias wrote:
>> Hello, please review this small change to os_linux.cpp  .
>>
>> It  uses the  recently introduced    _print_ascii_file_h
>> Function t more places (makes the code  a bit  shorter ) .
>>
>>
>> Bug/webrev :
>>
>> https://bugs.openjdk.java.net/browse/JDK-8244196
>>
>> http://cr.openjdk.java.net/~mbaesken/webrevs/8244196.0/
>>
>> Thanks, Matthias