RFR: 8247524: Remove unnecessary volatile qualifiers from member functions
Kim Barrett
kim.barrett at oracle.com
Mon Jun 15 06:48:42 UTC 2020
> On Jun 15, 2020, at 1:59 AM, Stefan Karlsson <stefan.karlsson at oracle.com> wrote:
>
> Looks good.
Thanks.
> StefanK
>
> On 2020-06-15 01:15, Kim Barrett wrote:
>> Please review this change to oopDesc and Metadata classes, removing
>> unnecessary volatile qualifiers from some member functions.
>>
>> This change also makes virtual overrides of the relevant functions
>> explicitly virtual.
>>
>> While there, removed unnecessary workaround in oopDesc::klass_or_null_acquire.
>>
>> After this change,
>> egrep -r -H --exclude-dir=.hg "\)\s*(const |)\s*volatile" src/hotspot
>> finds nothing; there seem to be no remaining volatile qualified methods.
>>
>> CR:
>> https://bugs.openjdk.java.net/browse/JDK-8247524
>>
>> Webrev:
>> https://cr.openjdk.java.net/~kbarrett/8247524/open.00/
>>
>> Testing:
>> mach5 tier1-3
More information about the hotspot-dev
mailing list