[PING] RFR [XS]: 8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java

[Bob Vandette]

Should we just accept the kernel error message rather than add all the additional value checking?

     "out.shouldContain("Your kernel does not support swap limit capabilities”);

Why isn’t the try block around the check for .shouldMatch("OperatingSystemMXBean\\.getFreeSwapSpaceSize: [1-9][0-9]+”); ?
Why doesn’t this call fail as well??

Have you tried this test on a system with cgrouopv1 and v2 that doesn’t have swap enabled?

I’m concerned that we’ll be back to fixing this when some other configuration combination fails.

Bob.


> On Jun 17, 2020, at 5:13 AM, Severin Gehwolf <sgehwolf at redhat.com> wrote:
> 
> On Fri, 2020-06-05 at 16:07 +0200, Severin Gehwolf wrote:
>> On Fri, 2020-06-05 at 10:30 +0000, Baesken, Matthias wrote:
>>>> Here would be my suggestion
>>>> (hopefully this one isn't too restrictive again):
>>>> http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8244500/03/webrev/
>>> 
>>> Hi Severin, this worked nicely .
>>> Thanks for providing this .
>> 
>> Great. If somebody else is willing to OK this, I'll push it.
> 
> Could I have a second review of this, please? I believe it's the best
> we can do for this test failure Matthias is seeing.
> 
> Thanks,
> Severin
>