RFR(T) [15] : 8247716 : JVM_RegisterWhiteBoxMethods checks wrong classloader

Igor Ignatyev igor.ignatyev at oracle.com
Wed Jun 17 14:43:07 UTC 2020


Hi Dan,

thanks for your review, pushed.

-- Igor

> On Jun 17, 2020, at 7:28 AM, Daniel D. Daugherty <daniel.daugherty at oracle.com> wrote:
> 
> On 6/16/20 11:39 PM, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev//8247716/webrev.00
> 
> src/hotspot/share/prims/whitebox.cpp
>     No comments.
> 
> Thumbs up and I agree that this is a trivial fix.
> 
> Dan
> 
> 
>>> 1 line changed: 0 ins; 0 del; 1 mod;
>> 
>> Hi all,
>> 
>> could you please review this one-liner fix for JVM_RegisterWhiteBoxMethods method?
>> from JBS:
>>> JVM_RegisterWhiteBoxMethods is supposed to check that sun.hotspot.WhiteBox class is loaded by the boot classloader, yet it actually checks that java.lang.Class class is.
>> note: this had no impact, as NativeLookup::lookup_style would use JVM_RegisterWhiteBoxMethods as sun.hotspot.WhiteBox::registerNatives only if the class was load by the boot loader.
>> 
>> testing: tier1
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8247716
>> webrev: http://cr.openjdk.java.net/~iignatyev//8247716/webrev.00
>> 
>> Thanks,
>> -- Igor
> 



More information about the hotspot-dev mailing list