[15] RFR(XS): 8245128: Kitchensink fails with: assert(destination == (address)-1 || destination == entry) failed: b) MT-unsafe modification of inline cache

[Christian Hagedorn]

Hi

Please review the following patch:
https://bugs.openjdk.java.net/browse/JDK-8245128
http://cr.openjdk.java.net/~chagedorn/8245128/webrev.00/

The assert is often hit when enabling the Kitchensink instrumentation 
module which triggers a lot of class redefinitions. The problem looks 
similar to the one fixed in JDK-8225681 [1] for the other a) MT-unsafe 
assert. We could be dealing with an old method which we should also 
exclude in the second b) MT-unsafe assert (JDK-8225681 fixed it only for 
a)). A nice description of the problem is found in the comment [2] by 
Erik Ö.

Applying this fix, the assert is not hit anymore with repeated 
Kitchensink runs with the instrumentation module enabled.

Thank you!

Best regards,
Christian


[1] https://bugs.openjdk.java.net/browse/JDK-8225681
[2] 
https://bugs.openjdk.java.net/browse/JDK-8225681?focusedCommentId=14278441&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14278441