[Urgent] RFR (XXS): 8248329: JDK-8244603 breaks windows build

Thomas Schatzl thomas.schatzl at oracle.com
Thu Jun 25 17:00:03 UTC 2020


Hi Dan, Sundar,

   thanks for your reviews (Strangely I have only received Dan's 
response yet, but not Sundar's nor the original message). Pushed.

Thanks,
   Thomas

On 25.06.20 18:56, Daniel D. Daugherty wrote:
> On 6/25/20 12:19 PM, Thomas Schatzl wrote:
>> Hi all,
>>
>>   can I have reviews for this small change that fixes the 
>> Windows-build JDK-8244603 broke.
>>
>> (It's also a bug for the other platforms but the compilers do not 
>> complain; it would have been fixed in an upcoming change as when I 
>> noticed that bug, I fixed it in a patch further up in my mq not part 
>> of this push. This is why it slipped through).
>>
>> CR:
>> https://bugs.openjdk.java.net/browse/JDK-8248329
>> Webrev:
>> http://cr.openjdk.java.net/~tschatzl/8248329/webrev/
> 
> src/hotspot/share/gc/g1/g1Policy.cpp
>      No comments.
> 
> Thumbs up! I consider this a trivial change so you do not have to wait
> for 24 hours to push.
> 
> Dan
> 
> 
> 
>> Testing:
>> tier-1 passed
>>
>> Sorry for the issue,
>>   Thomas
> 



More information about the hotspot-dev mailing list