RFR [XS]: 8240603: Windows 32bit compile error after 8238676

[Langer, Christoph]

+1

-----Original Message-----
From: hotspot-dev <hotspot-dev-bounces at openjdk.java.net> On Behalf Of David Holmes
Sent: Donnerstag, 5. März 2020 14:24
To: Baesken, Matthias <matthias.baesken at sap.com>; 'hotspot-dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
Subject: Re: RFR [XS]: 8240603: Windows 32bit compile error after 8238676

Sorry about that oversight.

Looks good - thanks for fixing.

I'd classify this as trivial.

David

On 5/03/2020 10:25 pm, Baesken, Matthias wrote:
> Hello ,  please look into the following small change .
> We noticed that the Windows 32 bit builds fail  now  in jdk/jdk .
> 
> Error :
> libatExit.c(107): error C2373: 'JNI_OnLoad': redefinition; different type modifiers
> d:\output-jdk-dev\support\modules_include\java.base\jni.h(1970): note: see declaration of 'JNI_OnLoad'
> 
> Looks like the recent change  "8238676: jni crashes on accessing it from process exit hook"
> caused this; we need on Windows 32 bit
> 
> JNIEXPORT jint JNICALL
> JNI_OnLoad(JavaVM *jvm, void *reserved) {  ... }
> 
> 
> to avoid this .
> 
> Bug/webrev :
> 
> https://bugs.openjdk.java.net/browse/JDK-8240603
> 
> http://cr.openjdk.java.net/~mbaesken/webrevs/8240603.0/
> 
> 
> Thanks, Matthias
>