RFR: 8235908: omit ThreadPriorityPolicy warning when value is set from image

[Langer, Christoph]

Hi,

the changes look good. However, I think we should make this behavior consistent and also handle Windows, Solaris and AIX the same way.

Cheers
Christoph

-----Original Message-----
From: hotspot-dev <hotspot-dev-bounces at openjdk.java.net> On Behalf Of David Holmes
Sent: Montag, 9. März 2020 05:33
To: Vladimir Kozlov <vladimir.kozlov at oracle.com>; Matthias Neugschwandtner <matthias.neugschwandtner at oracle.com>; 'hotspot-dev developers' <hotspot-dev at openjdk.java.net>
Subject: Re: RFR: 8235908: omit ThreadPriorityPolicy warning when value is set from image

The changes in relation to exposing the origin of the flag as a 
JIMAGE_RESOURCE look fine. (Could potentially have been its own RFE but 
that's just bookkeeping.)

No further comment on the actual ThreadPriorityPolicy change. :)

Cheers,
David

On 7/03/2020 3:51 am, Vladimir Kozlov wrote:
> I changed mailing list to wider audience.
> 
> Note for reviews, Java SE builds and products are not affected by this 
> change.
> 
> This change affects only GraalVM which sets ThreadPriorityPolicy=1 by 
> default in their build.
> GraalVM release notes have statement about that to notify GraalVM users 
> because it may affect applications performance.
> 
> RFE describes why GraalVM needs that.
> 
> Change looks good to me.
> 
> Thanks,
> Vladimir K
> 
> On 3/6/20 12:56 AM, Matthias Neugschwandtner wrote:
>> Hello everyone,
>>
>> Please review this change, which omits the warning that 
>> ThreadPriorityPolicy=1 requires system level permission if the value 
>> is set via jlink, the same way it is omitted if the value is set by 
>> default.
>>
>> https://bugs.openjdk.java.net/browse/JDK-8235908
>> http://cr.openjdk.java.net/~mneugschwand/8235908
>>
>> Thank you,
>> Matthias