RFR [XXS]: 8241660: Add virtualization information output to hs_err file on macOS

Doerr, Martin martin.doerr at sap.com
Fri Mar 27 11:26:39 UTC 2020


Hi Matthias,

looks good to me, too.

Best regards,
Martin


> -----Original Message-----
> From: Baesken, Matthias <matthias.baesken at sap.com>
> Sent: Freitag, 27. März 2020 11:54
> To: Langer, Christoph <christoph.langer at sap.com>; 'hotspot-
> dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
> Cc: Doerr, Martin <martin.doerr at sap.com>
> Subject: RE: RFR [XXS]: 8241660: Add virtualization information output to
> hs_err file on macOS
> 
> Thanks, may I get a second review please ?
> 
> 
> -----Original Message-----
> From: Langer, Christoph <christoph.langer at sap.com>
> Sent: Freitag, 27. März 2020 10:51
> To: Baesken, Matthias <matthias.baesken at sap.com>; 'hotspot-
> dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
> Subject: RE: RFR [XXS]: 8241660: Add virtualization information output to
> hs_err file on macOS
> 
> Hi Matthias,
> 
> this looks good to me.
> 
> Best regards
> Christoph
> 
> 
> >
> > Hello , please review this very small enhancement  to the hs_err file output
> > on macOS .
> >
> > Currently we miss the output of virtualization information in the hs_err file
> > on macOS, although we collect the info already in early JVM startup.
> >
> > This patch adds the information.
> >
> > Bug/webrev :
> >
> > https://bugs.openjdk.java.net/browse/JDK-8241660
> >
> > http://cr.openjdk.java.net/~mbaesken/webrevs/8241660.0/
> >
> > Thanks, Matthias



More information about the hotspot-dev mailing list