RFR(S): 8233014: Enable ShowCodeDetailsInExceptionMessages per default.
David Holmes
david.holmes at oracle.com
Fri May 8 10:22:55 UTC 2020
On 8/05/2020 8:10 pm, Lindenmaier, Goetz wrote:
> Hi David,
>
>> I have reviewed the CSR.
> Thanks a lot!
> Should I move it back to draft?
Back to Draft then to Finalized.
Cheers,
David
>>> ...
>>> So I think this is the right point of time to enable it.
>> Okay that sounds quite reasonable.
> Thanks!
>
>> Yeah I don't know what was done before. I'll run it through our testing
>> again while you wait for the CSR approval.
> That's great, thanks a lot.
>
> Best regards,
> Goetz.
>
>
>>
>> Thanks,
>> David
>>
>>> Best regards,
>>> Goetz.
>>>
>>>
>>>
>>>
>>>
>>>
>>>> -----Original Message-----
>>>> From: David Holmes <david.holmes at oracle.com>
>>>> Sent: Monday, April 27, 2020 1:08 AM
>>>> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; 'hotspot-
>>>> dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
>>>> Subject: Re: RFR(S): 8233014: Enable
>> ShowCodeDetailsInExceptionMessages
>>>> per default.
>>>>
>>>> Hi Goetz,
>>>>
>>>> On 27/04/2020 8:02 am, David Holmes wrote:
>>>>> Hi Goetz,
>>>>>
>>>>> This will need a CSR request to change the default flag value.
>>>>
>>>> On that front, given this feature only just shipped in 14, on what basis
>>>> are we ready to flip the flag in 15? We have no feedback on the feature
>>>> and would not likely get any for some time.
>>>>
>>>>> Otherwise change looks okay to me.
>>>>
>>>> With regards to testing however, please ensure that turning this on does
>>>> not inadvertently disrupt any tests. Passing jdk-submit is a minimal
>>>> requirement here and more extensive testing is desirable.
>>>>
>>>> Thanks,
>>>> David
>>>>
>>>>> Thanks,
>>>>> David
>>>>>
>>>>> On 25/04/2020 12:36 am, Lindenmaier, Goetz wrote:
>>>>>> Hi,
>>>>>>
>>>>>> I would like to enable JEP 358 Helpful NullPointerExceptions by default:
>>>>>>
>>>>>> http://cr.openjdk.java.net/~goetz/wr19/8233014-
>>>> enable_NPE_per_default/02/
>>>>>>
>>>>>> Please review.
>>>>>>
>>>>>> The change passed our testing and jdk-submit.
>>>>>>
>>>>>> Best regards,
>>>>>> Goetz.
>>>>>>
More information about the hotspot-dev
mailing list