RFR [XS]: 8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java

[Baesken, Matthias]

Hello, here is a new webrev removing the comment :

http://cr.openjdk.java.net/~mbaesken/webrevs/8244500.1/

It removes the comment , and it also  handles  0  for getFreeSwapSpaceSize     
(  this can occur  after   JDK-8242480 : Negative value may be returned by getFreeSwapSpaceSize() in the docker   was pushed  recently ).

Best regards, Matthias

-----Original Message-----
From: Baesken, Matthias 
Sent: Mittwoch, 13. Mai 2020 10:11
To: 'David Holmes' <david.holmes at oracle.com>; 'hotspot-dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
Subject: RE: RFR [XS]: 8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java


>But according to the comment immediately before your changes:
>
>// in case of warnings like : "Your kernel does not support swap limit 
>capabilities or the cgroup is not mounted. Memory limited without swap."
>// the getTotalSwapSpaceSize does not return the expected result, but 0
>
>we should be returning zero. So this seems to be a bug in the 
>implementation not in the test.

 
Hi David , I think  in case of  "Your kernel does not support swap limit  capabilities   ... "    we just do not get the values
 that are normally expected.
Previously we indeed got "0" .
Probably the comment should be deleted .

Best regards, Matthias