RFR: 8243996: Remove hardcoded field offsets from HotSpot

John Rose john.r.rose at oracle.com
Thu May 14 19:12:03 UTC 2020


On May 14, 2020, at 2:30 AM, Erik Österlund <erik.osterlund at oracle.com> wrote:
> ...
> I could send
> a new RFR trying to normalize the style of the various offsets in JavaClasses to use a leading '_', be private
> and have an accessor function that asserts offset sanity. What do you think?

That is a fine idea; thanks for suggesting it.

> Not sure how I got here implementing support for compressed class pointers in the absence of compressed
> oops. Oh dear…

Indeed.  That’s how it goes with this code base.

Sometimes it’s as if you pick at a little thread on your sleeve, and
then it animates and starts to wrap itself around your finger.
Suddenly you realize your sleeve is full of swaying fibers…  :-)

— John

P.S. To deal with Emacs macro seizures, I have this in my Preferences.el:

(push '("/vmSymbols\\.hpp\\'" . fundamental-mode) auto-mode-alist)
(push '("/globals\\.hpp\\'" . fundamental-mode) auto-mode-alist)
(push '("/vmStructs\\.cpp\\'" . fundamental-mode) auto-mode-alist)



More information about the hotspot-dev mailing list