RFR: 8245002: Windows GDI functions don't support NUMA interleaving

Kim Barrett kim.barrett at oracle.com
Fri May 15 18:39:13 UTC 2020


> On May 15, 2020, at 1:46 PM, Stefan Karlsson <stefan.karlsson at oracle.com> wrote:
> 
> Hi all,
> 
> Please review this patch to turn off -XX:+UseNUMAInterleaving as long as Windows GDI functions don't work with memory that crosses memory reservation boundaries.
> 
> https://cr.openjdk.java.net/~stefank/8245002/webrev.00.cleanup
> https://cr.openjdk.java.net/~stefank/8245002/webrev.01.workaround
> https://cr.openjdk.java.net/~stefank/8245002/webrev.all
> 
> https://bugs.openjdk.java.net/browse/JDK-8245002

------------------------------------------------------------------------------
src/hotspot/os/windows/os_windows.cpp
2753   void* verify_mem = ::malloc(4 * 1024);

There's no corresponding free.

------------------------------------------------------------------------------
src/hotspot/os/windows/os_windows.cpp
2776     assert(false, "Reservation failed");
2791     assert(false, "Failed to commit memory");
2802     assert(false, "Failed to commit memory");

These look like leftover debugging code?

------------------------------------------------------------------------------



More information about the hotspot-dev mailing list