RFR (S) 8242424: Deprecate InitialBootClassLoaderMetaspaceSize

[Thomas Stüfe]

Hi,

I ran the following tests:

hotspot/jtreg/runtime/Metaspace/MaxMetaspaceSizeTest.java
hotspot/jtreg/runtime/cds/MaxMetaspaceSize.java
hotspot/jtreg/runtime/CommandLine/OptionsValidation/TestOptionsWithRanges.java
hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java
hotspot/jtreg/runtime/cds/appcds/sharedStrings/LargePages.java
hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java
hotspot/jtreg/gc/TestSystemGC.java

and all of hotspot/jtreg/vmTestbase/metaspace/...

successfully with Coleens patch.

Cheers, Thomas




On Sat, May 16, 2020 at 3:27 PM Daniel D. Daugherty <
daniel.daugherty at oracle.com> wrote:

> On 5/15/20 6:55 PM, coleen.phillimore at oracle.com wrote:
> > Also:
> > 8243147: Deprecate UseLargePagesInMetaspace
> >
> > Summary: mark these options for deprecation
> >
> > Tested with tier1-3.
> >
> > open webrev at
> http://cr.openjdk.java.net/~coleenp/2020/8242424.01/webrev
>
> src/hotspot/share/runtime/arguments.cpp
>      No comments.
>
> src/hotspot/share/runtime/globals.hpp
>      No comments.
>
> test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java
>      No comments.
>
> Thumbs up on this part, but I see these options mentioned in tests:
>
> $ egrep -r
> 'UseLargePagesInMetaspace|InitialBootClassLoaderMetaspaceSize' open/test
> closed/test
> open/test/hotspot/jtreg/vmTestbase/metaspace/gc/MetaspaceBaseGC.java:
> useLargepages = PAGE_SIZE > 1_000_000 &&
> !vmArgs.contains("-XX:-UseLargePagesInMetaspace");
> open/test/hotspot/jtreg/runtime/CommandLine/OptionsValidation/TestOptionsWithRanges.java:
>
> excludeTestMaxRange("InitialBootClassLoaderMetaspaceSize");
> open/test/hotspot/jtreg/runtime/cds/MaxMetaspaceSize.java:
> processArgs.add("-XX:InitialBootClassLoaderMetaspaceSize=1m");
> open/test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/LargePages.java:
> "-XX:+UseLargePages", "-XX:+UseLargePagesInMetaspace");
> open/test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/LargePages.java:
> "-XX:+UseLargePages", "-XX:+UseLargePagesInMetaspace");
> open/test/hotspot/jtreg/runtime/Metaspace/MaxMetaspaceSizeTest.java:
> "-XX:InitialBootClassLoaderMetaspaceSize=4195328",
> open/test/hotspot/jtreg/gc/TestSystemGC.java: * @run main/othervm
> -XX:+UseLargePages -XX:+UseLargePagesInMetaspace gc.TestSystemGC
>
> Do you know of the deprecated message will affect how these tests run?
>
> Dan
>
>
>
> > bug link https://bugs.openjdk.java.net/browse/JDK-8242424
> > bug link https://bugs.openjdk.java.net/browse/JDK-8243147
> >
> > Thanks,
> > Coleen
>
>