RFR: 8245002: Windows GDI functions don't support NUMA interleaving

[Thomas Schatzl]

Hi,

On 19.05.20 13:53, Stefan Karlsson wrote:
> Updated webrevs:
>   https://cr.openjdk.java.net/~stefank/8245002/webrev.02.workaround.kims-review
>   https://cr.openjdk.java.net/~stefank/8245002/webrev.all.kims-review

- s/adjecent/adjacent

- From CreateBitmap documentation 
(https://docs.microsoft.com/en-us/windows/win32/api/wingdi/nf-wingdi-createbitmap):

"A pointer to an array of color data used to set the colors in a 
rectangle of pixels. Each scan line in the rectangle must be word 
aligned (scan lines that are not word aligned must be padded with 
zeros). If this parameter is NULL, the contents of the new bitmap is 
undefined."

I am not sure if that alignment requirement refers to the start of the 
scanline or the length of the scanline (or both), it seems that this 
refers to the length only though.

In your example the start of the first (and only) scanline is guaranteed 
to be not word aligned (2808   void* bitmapBits = (char*)mem1 - 1;) so 
this test may fail (on different Windows versions?) for different reasons.

Since the code seems to work, I am okay with it though.

If you only intend to fix the typo, I do not need a re-review.

Looks good.

Thanks,
   Thomas