RFR: 8245002: Windows GDI functions don't support NUMA interleaving

stefan.johansson at oracle.com stefan.johansson at oracle.com
Tue May 19 15:21:32 UTC 2020


Hi Stefan,

On 2020-05-19 16:04, Stefan Karlsson wrote:
> 
> However, I've updated the code to ensure that both memory and and width 
> bytes are aligned, just to be sure. I've also added some more comments 
> to describe the chosen value:
> 
> https://cr.openjdk.java.net/~stefank/8245002/webrev.03.workaround.thomas-review/ 
> 
> https://cr.openjdk.java.net/~stefank/8245002/webrev.all.thomas-review/

Still good, but if you like you can add parentheses around the division 
in the nBitCount calculation to make it easier to read.

Thanks,
Stefan

> 
> Thanks,
> StefanK
> 
>>
>> Looks good.
>>
>> Thanks,
>>    Thomas


More information about the hotspot-dev mailing list