RFR: 8245002: Windows GDI functions don't support NUMA interleaving

[Thomas Schatzl]

Hi,

On 19.05.20 16:04, Stefan Karlsson wrote:
> 
> 
> On 2020-05-19 14:23, Thomas Schatzl wrote:
>> Hi,
>>
>> On 19.05.20 13:53, Stefan Karlsson wrote:
>>> Updated webrevs:
>>>   https://cr.openjdk.java.net/~stefank/8245002/webrev.02.workaround.kims-review 
>>>
>>>   https://cr.openjdk.java.net/~stefank/8245002/webrev.all.kims-review
>>
>> - s/adjecent/adjacent
> 
> Fixed.
> 
>>
[...]>> In your example the start of the first (and only) scanline is
>> guaranteed to be not word aligned (2808   void* bitmapBits = 
>> (char*)mem1 - 1;) so this test may fail (on different Windows 
>> versions?) for different reasons.
>>
>> Since the code seems to work, I am okay with it though.
>>
>> If you only intend to fix the typo, I do not need a re-review.
> 
> I've tested by misaligning the memory, and it seems to work.
> 
> However, I've updated the code to ensure that both memory and and width 
> bytes are aligned, just to be sure. I've also added some more comments 
> to describe the chosen value:
> 
> https://cr.openjdk.java.net/~stefank/8245002/webrev.03.workaround.thomas-review/ 
> 
> https://cr.openjdk.java.net/~stefank/8245002/webrev.all.thomas-review/
> 

   lgtm.

Thomas