RFR: 8245723: Remove PrintCompressedOopsMode and gc+heap+coops info log to debug level

stefan.johansson at oracle.com stefan.johansson at oracle.com
Tue May 26 13:38:41 UTC 2020


Thanks for the review David,

On 2020-05-26 15:22, David Holmes wrote:
> Hi Stefan,
> 
> That all seems fine to me.
> 
> Aside: I couldn't tell why 
> runtime/CompressedOops/CompressedClassPointers.java was actually using 
> the flag. Do you think it is just for additional diagnostics in case of 
> failure?
Yes, I think so. I thought about skipping it, but on the other hand it 
might be helpful in case of a failure.

Cheers,
Stefan

> 
> Thanks,
> David
> 
> On 26/05/2020 10:16 pm, stefan.johansson at oracle.com wrote:
>> Hi,
>>
>> Please review this change that removes the deprecated diagnostic 
>> option PrintCompressedOopsMode.
>>
>> Webrev: http://cr.openjdk.java.net/~sjohanss/8245723/00/
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8245723
>>
>> Summary
>> After adding the new gc+init logging in JDK-8244817, the info logging 
>> on gc+heap+coops can be moved to debug level. When looking into this I 
>> realized that gc+heap+coops=info has an old alias flag, 
>> PrintCompressedOopsMode, connected to it. I see no reason keeping this 
>> flag around and from what I understand we don't need to do anything 
>> special since it has been deprecated since JDK 9.
>>
>> Testing
>> Locally verified output and run the tests affected. Also Mach5 tier1-2.
>>
>> Thanks,
>> Stefan


More information about the hotspot-dev mailing list